Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 03-25-2024 take 2 #683

Closed
wants to merge 14 commits into from
Closed

Release 03-25-2024 take 2 #683

wants to merge 14 commits into from

Conversation

YazeedLoonat
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses #issue

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Please include a summary of the change and which issue(s) is addressed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Can This Be Tested/Reviewed?

Provide instructions so we can review.

Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

emilyjablonski and others added 13 commits March 25, 2024 15:06
@emilyjablonski @YazeedLoonat
refactor: uptake and merge card (bloom-housing#3922)
c3dad74
@YazeedLoonat
feat: new single use code login endpoint (bloom-housing#3928)
eae432f 
* feat: new single use code login endpoint

* fix: updates per pr comments
@YazeedLoonat @cade-exygy
feat: unconfirmed user login error fix (bloom-housing#3949)
b142f21 
* feat: unconfirmed user login error fix

* fix: unconfirmed user attempting to login, public user logging into partner site, seeding es

* updates per cade

* fix: undefined check

* Merge remote-tracking branch 'origin/main' into security-patch-2

* fix: merge mistakes were made

---------

Co-authored-by: Cade Wolcott <[email protected]>
@emilyjablonski @YazeedLoonat
feat: passwordless frontend (bloom-housing#3941)
5e68ec2
@ludtkemorgan @YazeedLoonat
fix: geocoding layer fix (bloom-housing#3951)
305feac
@emilyjablonski @YazeedLoonat
feat: pwdless sign in flow (bloom-housing#3960)
24a92b0
@YazeedLoonat
feat: creating rate limiting (bloom-housing#3961)
8efa5d6
@YazeedLoonat
fix: possibly throttling through the proxy stuff (bloom-housing#3966)
9f46f96
@emilyjablonski @YazeedLoonat
feat: pwdless create account flow (bloom-housing#3964)
7a3f8a3
@YazeedLoonat
fix: Proxy attempt3 (bloom-housing#3967)
bd73512 
* fix: possibly throttling through the proxy stuff

* fix: changing logging to get some more info hopefully

* fix: small logging tweak

* fix: forwarding fix

* fix: removings logs
@YazeedLoonat
feat: Throttle update for proxy (bloom-housing#3968)
1ba186b 
* fix: proxy updates

* feat: modifying adapters to forward ip properly

* fix: adjusting for hosted env

* fix: updates after testing with next proxy

* fix: clean up
@YazeedLoonat
feat: better memory management on app export (bloom-housing#3965)
053be47
@ColinBuyck @YazeedLoonat
fix: update naming to applicantWorkAddress (bloom-housing#3975)
d0b0405 
* fix: update naming to applicantWorkAddress

* fix: clean up erroring
@netlify Netlify
Copy link

netlify bot commented Mar 25, 2024 •
edited
Loading

✅ Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit e8589bb
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/6601fbef0b972b000871959c
😎 Deploy Preview https://deploy-preview-683--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@YazeedLoonat YazeedLoonat changed the title Hba release 03 25 2024 2 Release 03-25-2024 take 2 Mar 25, 2024
@YazeedLoonat
Copy link
Collaborator Author

closing in favor of: #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YazeedLoonat @emilyjablonski @ludtkemorgan @ColinBuyck